Convert CodeMirror theme toggling behavior to Extension #9063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
authored with codex, using previous two commits as examples.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
franknoirot
changed the base branch from
main
to
franknoirot/8880/kill-a-provider
We need it to wait until <App/> mounts to fire
… true Which broke the web app
franknoirot
force-pushed
the
franknoirot/8880/editor-theme-extension
branch
from
dfccc37 to
fa421d3
Compare
franknoirot
force-pushed
the
franknoirot/8880/kill-a-provider
branch
from
b4be5ad to
a6ed618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on #9058, more towards #8880. After consolidating
KclManager, we need to do a number of things:StateFieldsandEditorView.updateListener.of's to push and pull from CodeMirror state as we canKclManagerto be able to spin up multiple CodeMirror buffers and manage them independently.codemirror-reactand instead just mountCodeMirror"statically" as far as React is concerned, because all the state concerning it is completely out of React.This PR is a small proof-of-concept to show how an aspect of CodeMirror that's bound in React—the theme toggling—can be decoupled from React by converting it to a CodeMirror
Extensionand adding a method toKclManagerto dispatch an effect for it CodeMirror instead. I suspect there might be an even more encapsulated way to define this without a method, which just automatically listens to the reactive value of the setting within the extension definition, but this gets it out of React without losing reactivity for now.Users should experience no change in behavior after this PR.