AutoMerge: add is_pkgname_similar
#484
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lar to existing package names
ericphanson
reviewed
Nov 9, 2022
Member
ericphanson
left a comment
ericphanson
left a comment
There was a problem hiding this comment.
can you undo the unrelated formatting changes? it makes it harder to review
DilumAluthge
changed the title
is_pkgname_similar is_pkgname_similar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i refactored a bit to make it easier to check if your package name is too similar to existing package names
i think tests rely on having the uncompressed General, so I don't know if tests pass yet.
the reason I wanted this is so I could build a
pkg_searchfunction that lets me search for packages from the replvery sorry for juliaformatter