Skip to content

Only alert about actual new versions #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Only alert about actual new versions #1319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions src/command_status.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ use cli_table::{
};
use itertools::Itertools;
use numeric_sort::cmp;
use semver::Version;

fn format_linked_command(command: &str, args: &Option<Vec<String>>) -> String {
let mut combined_command = String::new();
Expand Down Expand Up @@ -73,8 +74,14 @@ fn get_update_info(
} => (local_etag != server_etag).then(|| "Update available".to_string()),
JuliaupConfigChannel::SystemChannel { version } => {
match versiondb_data.available_channels.get(channel_name) {
Some(channel) if &channel.version != version => {
Some(format!("Update to {} available", channel.version))
Some(channel) => {
// Parse both versions and compare semantically
match (Version::parse(version), Version::parse(&channel.version)) {
(Ok(installed_ver), Ok(available_ver)) if available_ver > installed_ver => {
Some(format!("Update to {} available", channel.version))
}
_ => None,
}
}
_ => None,
}
Expand All @@ -90,8 +97,16 @@ fn get_update_info(
}) => (local_etag != server_etag).then(|| "Update available".to_string()),
Some(JuliaupConfigChannel::SystemChannel { version }) => {
match versiondb_data.available_channels.get(target) {
Some(channel) if channel.version != *version => {
Some(format!("Update to {} available", channel.version))
Some(channel) => {
// Parse both versions and compare semantically
match (Version::parse(version), Version::parse(&channel.version)) {
(Ok(installed_ver), Ok(available_ver))
if available_ver > installed_ver =>
{
Some(format!("Update to {} available", channel.version))
}
_ => None,
}
}
_ => None,
}
Expand Down