Enhance type flexibility for PoincareMap & Add a Bigfloat test #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Poincaré mapping.
Datseris
reviewed
Nov 10, 2025
Member
Datseris
left a comment
Datseris
left a comment
There was a problem hiding this comment.
Thanks, do you mind incrementing patch version number in Project.toml?
Datseris
approved these changes
Nov 12, 2025
Member
|
error is unrelated, thanks for your contqribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #237
This PR adds flexibility for data types in Poincaré mapping, especially enabling its use with
BigFloat.In
DynamicalSystems.jl, the type of time variabletis inherited from the type of the state variableu0.However, in the current implementation, the
PoincareMapstruct hard-codesFloat64for its argumentsTmaxandtcross.As a result, constructing a dynamical system with
BigFloat(for example, to compute a high-precision Poincaré section) leads to a type error, which also limits the achievable numerical precision.This PR generalizes the struct by introducing a type parameter for flexibility.
The included test demonstrates that, with
Roots.jl, theBigFloat-based system now works correctly, and the Poincaré section can be obtained with high precision.