[pull] master from JuliaLang:master #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ason, these don't seem to "take" on our precompile workload. (#4114) Before: ``` julia> @time @eval Pkg.status() 0.470141 seconds (2.28 M allocations: 151.859 MiB, 2.91% gc time, 59.31% compilation time: 11% of which was recompilation) ``` After ``` julia> @time @eval Pkg.status() 0.220179 seconds (1.69 M allocations: 122.680 MiB, 6.14% gc time, 25.84% compilation time: 74% of which was recompilation) ``` Co-authored-by: KristofferC <[email protected]>
* precompile registry update Before ``` julia> @time @eval Pkg.Registry.update() Updating registry at `~/.julia/registries/General.toml` 1.006864 seconds (2.18 M allocations: 148.068 MiB, 1.42% gc time, 43.47% compilation time: 6% of which was recompilation) ``` After ``` julia> @time @eval Pkg.Registry.update() Updating registry at `~/.julia/registries/General.toml` 0.677679 seconds (1.75 M allocations: 125.226 MiB, 2.03% gc time, 14.63% compilation time: 39% of which was recompilation) ``` * add some explicit precompile statements for `Pkg.add` For some reason, these don't seem to "take" on our precompile workload. Before: ``` 1.379429 seconds (3.39 M allocations: 211.476 MiB, 2.36% gc time, 60.64% compilation time: 38% of which was recompilation) ``` After: ``` 0.963989 seconds (2.83 M allocations: 182.510 MiB, 1.67% gc time, 42.22% compilation time: 75% of which was recompilation) ``` * remove call to update registry --------- Co-authored-by: KristofferC <[email protected]>
… file in the project deps (#4117)
…t package is user writable. This allows running the Pkg tests as part of Base.runtests of an installed Julia installation, where sources might be readonly. (#4136)
This provides initial support for defining "apps" in Julia which can be run from the terminal and installed via Pkg.
…fore precompilation is finished instead of `__init__` (#4142) Co-authored-by: KristofferC <[email protected]>
…h a binary is already installed (#4143) Co-authored-by: KristofferC <[email protected]>
It turns out that Windows requires the executable bit set if the `BYPASS_TRAVERSE_CHECKING` privilege is not attached to a user's account. It's simply more correct to ensure that our directories have this bit set, and unfortunately our `filemode()` function call is not complete on Windows and does not include this bit, so we manually add it in on Windows.
Given TODO and JuliaLang/julia#33212 is fixed (closed)
…ess threads (#4141) Co-authored-by: Ian Butterworth <[email protected]>
) * protect against an interrupted mv * pidlock download_source * add tests * try a proper package * actually test ffmpeg works * windows fix * pidlock artifact downloads * don't claim to have done work * more tests * debug hang * debug: try a yield * increase stale_age for downloads * rm debugs * use (and rename) mv_temp_artifact_dir * disable modifying permissions in mv_temp_artifact_dir * rm goto's * rename as generic and move to utils * reduce to 1 test. lock ffmpeg version. * show info if test fails * debug: turn on verbose testsets for timing * tweaks * fix error printing * check which registries need installing after acquiring pidlock * rm ispath check outside of pidlock * add time print * color process prints * use early throw `Base.Experimental.@sync` * narrow try * reduce stale_age * fix! * remove print from happy path * also pidlock git installs
Co-authored-by: KristofferC <[email protected]>
Co-authored-by: KristofferC <[email protected]>
Co-authored-by: KristofferC <[email protected]>
* test: isolate more tests that call subprocesses The base `make test-Pkg` invocation sets JULIA_DEPOT_PATH to the builtin DEPOT_PATH. However, Pkg tests assume that this DEPOT_PATH do not have any registries. There were various places where we were accidentally using this DEPOT_PATH and installing a registry there. Work around this by unsetting it, isolating some subprocesses and adding a check on CI that fails if any pre-set JULIA_DEPOT_PATH gets modified. Ref JuliaLang/julia#60058 * See if Linux would work at least * code format * Try windows env setup * One more format complaint * Run with JULIA_DEBUG to debug loading failures * Use runner rather than matrix in conditional * More debug logging * Embarassing typo * rm CI check again
Co-authored-by: KristofferC <[email protected]>
Co-authored-by: Keno Fischer <[email protected]>
* Isolate more tests As seen in JuliaLang/julia#60197, the test I added to make sure that `make test-Pkg` doesn't corrupt the builtin depot is firing properly - we had several more tests that were improperly isolated. A related issue is that if `Preferences` is not in the depot that starts the test we were trying to Pkg.add it, causing the same problem. Fix that by treating it like the other external packages (Aqua, HistoricalStdlibVersions) and making the corresponding tests optional. * Try to use the LAODED_DEPOT ReplExt copy
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
7z appears to normalize internally causing it to fail to extract archives that have this pattern. One way to reproduce is to set DEPOT_PATH to a path that has a symlink/.. in the path. We get this wrong in Julia too, c.f. JuliaLang/julia#60251
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
48 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )