Add PowerVS data sources: ibm_pi_instance_network and ibm_pi_instance_networks #6564
+508
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump github.com/IBM-Cloud/power-go-client to pick up the InstanceNetworks client needed by the new data sources.
Register ibm_pi_instance_network and ibm_pi_instance_networks in the provider. Add new arg/attr constants (ip_address, href, version) used by these data sources.
Add data sources for a single instance network (Get) and all networks (GetAll). Include flattenPvmInstanceNetworksv2 to expose external_ip, ip_address, mac_address, network IDs, href, and version. Single-network id is <cloud>/<instance>/<network>; list id is <cloud>/<instance>.
Cover id composition and presence of key attributes (network_id, network_interface_id, ip_address).
Add docs for d/pi_instance_network and d/pi_instance_networks with example usage, arguments, and attributes.
…wervs-ibm/terraform-provider-ibm into remove-pi-instance-network-datasource
r-patange
requested review from
hkantare,
kavya498,
omaraibrahim and
uibm
as code owners
michaelkad
added
service/Power Systems
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing: