Skip to content

Conversation

@michaelkad
Copy link
Collaborator

[R][D] vPMEM: instance vpmem volume
[R][D] vPMEM: instance vpmem volumes & instance
add ibm_pi_instance_vpmem_volumes
update doc
Update sdk
Update go.sum
Update with new sdk
update SDK
update SDK
fix SAP error
Fix formatting
Update SDK
Update changes
Update go.mod
Address comments
add timeouts to doc
Update go.mod with 1.14.3

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN TestAccIBMPIInstanceVPMEM
--- PASS: TestAccIBMPIInstanceVPMEM (898.31s)
PASS

=== RUN   TestAccIBMPIInstanceVpmemVolumeDataSourceBasic
--- PASS: TestAccIBMPIInstanceVpmemVolumeDataSourceBasic (46.95s)
PASS

=== RUN   TestAccIBMPIInstanceVpmemVolumesDataSourceBasic
--- PASS: TestAccIBMPIInstanceVpmemVolumesDataSourceBasic (53.83s)
PASS

=== RUN   TestAccIBMPIInstanceDataSource_basic
--- PASS: TestAccIBMPIInstanceDataSource_basic (42.23s)
PASS

=== RUN   TestAccIBMPISAPProfilesDataSourceBasic
--- PASS: TestAccIBMPISAPProfilesDataSourceBasic (16.57s)
PASS

=== RUN   TestAccIBMPISAPProfileDataSourceBasic
--- PASS: TestAccIBMPISAPProfileDataSourceBasic (14.37s)
PASS
...

@ismirlia
Copy link
Collaborator

This PR needs to be merged on December 9th after Q4 have been released in the service broker. Please start reviewing them now so that they'll be ready to merge by then. @hkantare and @yussufsh

@yussufsh
Copy link
Collaborator

@michaelkad @Alexander-Kita The doc changes need more review.. please update and all all the attributes from vpmemVolumeSchema().

@michaelkad michaelkad requested a review from yussufsh November 21, 2025 16:10
yussufsh
yussufsh previously approved these changes Nov 21, 2025
ismirlia
ismirlia previously approved these changes Nov 21, 2025
[R][D] vPMEM: instance vpmem volume
[R][D] vPMEM: instance vpmem volumes & instance
add ibm_pi_instance_vpmem_volumes
update doc
Update sdk
Update go.sum
Update with new sdk
update SDK
update SDK
fix SAP error
Fix formatting
Update SDK
Update changes
Update go.mod
Address comments
add timeouts to doc
Update go.mod with 1.14.3
ismirlia
ismirlia previously approved these changes Dec 1, 2025
@michaelkad michaelkad requested a review from yussufsh December 1, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge service/Power Systems Issues related to Power Systems

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants