feat(iampolicy): add role templates & assignments #6539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariarla
requested review from
hkantare,
kavya498,
omaraibrahim and
uibm
as code owners
hariarla
changed the title
hariarla
force-pushed
the
enable_role_templates
branch
3 times, most recently
from
b927359 to
db04d2c
Compare
Signed-off-by: Hari K Arla <[email protected]>
hariarla
force-pushed
the
enable_role_templates
branch
from
db04d2c to
30150cb
Compare
hariarla
changed the title
hariarla
changed the title
hkantare
reviewed
Nov 20, 2025
Collaborator
|
Import stmts in docs also have mismatch with required fields it requires two fields as per d.SetId(...) |
hkantare
reviewed
Nov 28, 2025
| Schema: map[string]*schema.Schema{ | ||
| "target": &schema.Schema{ | ||
| Type: schema.TypeList, | ||
| Computed: true, |
Collaborator
There was a problem hiding this comment.
Is this not a required argument? In create we do d.Get("target")
With this change the testcases should have failed
hkantare
reviewed
Nov 28, 2025
|
|
||
| ```hcl | ||
| data "ibm_iam_role_template" "iam_role_template" { | ||
| account_id = ibm_iam_role_template.iam_role_template_instance.account_id |
Collaborator
There was a problem hiding this comment.
account_id is n't defined in the schema for datasource "ibm_iam_role_template"
We are fetching account_id from the logged in user context
Collaborator
There was a problem hiding this comment.
In Schema we don't have any optional/required arguments only computed.
| ```hcl | ||
| data "ibm_iam_role_template_version" "iam_role_template_version" { | ||
| role_template_id = "role_template_id" | ||
| } |
Collaborator
There was a problem hiding this comment.
version is also required in Schema
| target { | ||
| type = "Account" | ||
| id = "id" | ||
| } |
Collaborator
There was a problem hiding this comment.
Templates is required parameter
Collaborator
|
We have 4 new datasources but docs were added only for 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing: