Skip to content

Conversation

@khipp
Copy link
Member

@khipp khipp commented Nov 3, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Copilot AI review requested due to automatic review settings November 3, 2025 02:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables the Mudlet cask due to a gatekeeper check failure. The change marks the cask as disabled with a future date, following the standard pattern used across the repository for similar failures.

  • Adds a disable! stanza indicating the cask fails macOS Gatekeeper checks

@khipp khipp changed the title mudlet: disable mudlet 4.19.1 Nov 3, 2025
@p-linnane
Copy link
Member

Probably time for disable! date: "2025-11-03", because: :unreachable.

@samford
Copy link
Member

samford commented Nov 3, 2025

Probably time for disable! date: "2025-11-03", because: :unreachable.

For what it's worth, the cask works fine outside of CI (even through a VPN). However, the app fails Gatekeeper checks, so its time may be limited anyway.

Whatever we do, this will need to be rebased to pick up the container change that was merged in the interim time.

@p-linnane
Copy link
Member

I think we decided to start marking things as unreachable if we are consistently having to skip checks in CI to get them merged.

@bevanjkay
Copy link
Member

It's strange for it to only fail in the CI environment, and not through Homebrew on a local machine.
It would be a shame to keep disabling casks that seemingly work fine elsewhere because there's a specific issue with CI.

I guess the CI IP ranges could be running into issues, but if that's a wider Cloudflare response then it's concerning for how wide it may impact other casks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants