-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
mudlet 4.19.1 #234914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
mudlet 4.19.1 #234914
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR disables the Mudlet cask due to a gatekeeper check failure. The change marks the cask as disabled with a future date, following the standard pattern used across the repository for similar failures.
- Adds a
disable!stanza indicating the cask fails macOS Gatekeeper checks
|
Probably time for |
For what it's worth, the cask works fine outside of CI (even through a VPN). However, the app fails Gatekeeper checks, so its time may be limited anyway. Whatever we do, this will need to be rebased to pick up the |
|
I think we decided to start marking things as unreachable if we are consistently having to skip checks in CI to get them merged. |
|
It's strange for it to only fail in the CI environment, and not through Homebrew on a local machine. I guess the CI IP ranges could be running into issues, but if that's a wider Cloudflare response then it's concerning for how wide it may impact other casks. |
1277cb5 to
94eb788
Compare
94eb788 to
fcb48b8
Compare
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.