-
Notifications
You must be signed in to change notification settings - Fork 3.6k
feat: Update full-text index name to include workspace label for bett… #2406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
After renaming the index, data migration must also be considered to ensure that indexes in legacy systems are properly updated to the new name. |
Co-authored-by: netbrah <[email protected]>
Co-authored-by: netbrah <[email protected]>
|
@
Did my last change address your requirements? Please let me know if you would to see any other updates |
This pull request makes a small but important change to the naming convention for full-text indexes in the Neo4j implementation. The index name now includes the
workspace_label, ensuring that each workspace has a uniquely named index and preventing potential naming conflicts.index_namein the_create_fulltext_indexmethod oflightrag/kg/neo4j_impl.pynow incorporates theworkspace_label, making the index name workspace-specific.Description
[Briefly describe the changes made in this pull request.]
Related Issues
[Reference any related issues or tasks addressed by this pull request.]
Changes Made
[List the specific changes made in this pull request.]
Checklist
Additional Notes
[Add any additional notes or context for the reviewer(s).]