Skip to content

Conversation

@netbrah
Copy link
Contributor

@netbrah netbrah commented Nov 22, 2025

This pull request makes a small but important change to the naming convention for full-text indexes in the Neo4j implementation. The index name now includes the workspace_label, ensuring that each workspace has a uniquely named index and preventing potential naming conflicts.

  • The index_name in the _create_fulltext_index method of lightrag/kg/neo4j_impl.py now incorporates the workspace_label, making the index name workspace-specific.

Description

[Briefly describe the changes made in this pull request.]

Related Issues

[Reference any related issues or tasks addressed by this pull request.]

Changes Made

[List the specific changes made in this pull request.]

Checklist

  • Changes tested locally
  • Code reviewed
  • Documentation updated (if necessary)
  • Unit tests added (if applicable)

Additional Notes

[Add any additional notes or context for the reviewer(s).]

@danielaskdd
Copy link
Collaborator

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danielaskdd
Copy link
Collaborator

After renaming the index, data migration must also be considered to ensure that indexes in legacy systems are properly updated to the new name.

@netbrah
Copy link
Contributor Author

netbrah commented Nov 23, 2025

@

After renaming the index, data migration must also be considered to ensure that indexes in legacy systems are properly updated to the new name.

Did my last change address your requirements? Please let me know if you would to see any other updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants