-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add embeddings & reranking via Sentence Transformers #2381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tomaarsen
wants to merge
2
commits into
HKUDS:main
Choose a base branch
from
tomaarsen:sentence_transformers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 changes: 75 additions & 0 deletions
75
examples/unofficial-sample/lightrag_sentence_transformers_demo.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| import os | ||
|
|
||
| from lightrag import LightRAG, QueryParam | ||
| from lightrag.llm.hf import hf_model_complete | ||
| from lightrag.llm.sentence_transformers import sentence_transformers_embed | ||
| from lightrag.utils import EmbeddingFunc | ||
| from sentence_transformers import SentenceTransformer | ||
|
|
||
| import asyncio | ||
| import nest_asyncio | ||
|
|
||
| nest_asyncio.apply() | ||
|
|
||
| WORKING_DIR = "./dickens" | ||
|
|
||
| if not os.path.exists(WORKING_DIR): | ||
| os.mkdir(WORKING_DIR) | ||
|
|
||
|
|
||
| async def initialize_rag(): | ||
| rag = LightRAG( | ||
| working_dir=WORKING_DIR, | ||
| llm_model_func=hf_model_complete, | ||
| llm_model_name="meta-llama/Llama-3.1-8B-Instruct", | ||
| embedding_func=EmbeddingFunc( | ||
| embedding_dim=384, | ||
| max_token_size=512, | ||
| func=lambda texts: sentence_transformers_embed( | ||
| texts, | ||
| model=SentenceTransformer("sentence-transformers/all-MiniLM-L6-v2"), | ||
| ), | ||
| ), | ||
| ) | ||
|
|
||
| await rag.initialize_storages() # Auto-initializes pipeline_status | ||
| return rag | ||
|
|
||
|
|
||
| def main(): | ||
| rag = asyncio.run(initialize_rag()) | ||
|
|
||
| with open("./book.txt", "r", encoding="utf-8") as f: | ||
| rag.insert(f.read()) | ||
|
|
||
| # Perform naive search | ||
| print( | ||
| rag.query( | ||
| "What are the top themes in this story?", param=QueryParam(mode="naive") | ||
| ) | ||
| ) | ||
|
|
||
| # Perform local search | ||
| print( | ||
| rag.query( | ||
| "What are the top themes in this story?", param=QueryParam(mode="local") | ||
| ) | ||
| ) | ||
|
|
||
| # Perform global search | ||
| print( | ||
| rag.query( | ||
| "What are the top themes in this story?", param=QueryParam(mode="global") | ||
| ) | ||
| ) | ||
|
|
||
| # Perform hybrid search | ||
| print( | ||
| rag.query( | ||
| "What are the top themes in this story?", param=QueryParam(mode="hybrid") | ||
| ) | ||
| ) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| main() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import pipmaster as pm # Pipmaster for dynamic library install | ||
|
|
||
| if not pm.is_installed("sentence_transformers"): | ||
| pm.install("sentence_transformers") | ||
| if not pm.is_installed("numpy"): | ||
| pm.install("numpy") | ||
|
|
||
| import numpy as np | ||
| from lightrag.utils import EmbeddingFunc | ||
| from sentence_transformers import SentenceTransformer | ||
|
|
||
|
|
||
| async def sentence_transformers_embed( | ||
| texts: list[str], model: SentenceTransformer | ||
| ) -> np.ndarray: | ||
| async def inner_encode( | ||
| texts: list[str], model: SentenceTransformer, embedding_dim: int = 1024 | ||
| ): | ||
| return model.encode( | ||
| texts, | ||
| truncate_dim=embedding_dim, | ||
| convert_to_numpy=True, | ||
| convert_to_tensor=False, | ||
| show_progress_bar=False, | ||
| ) | ||
|
|
||
| embedding_func = EmbeddingFunc( | ||
| embedding_dim=model.get_sentence_embedding_dimension(), | ||
| func=inner_encode, | ||
| max_token_size=model.get_max_seq_length(), | ||
| ) | ||
| return await embedding_func(texts, model=model) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Selecting the new
sentence_transformersembedding binding crashes immediately. The server block callsactual_func(texts, embedding_dim=embedding_dim)without ever constructing or passing aSentenceTransformerinstance, yetsentence_transformers_embed(lightrag/llm/sentence_transformers.py lines 13‑32) requires amodelpositional argument and does not acceptembedding_dim. As soon as the binding is chosen the API raisesTypeError(missingmodel/ unexpectedembedding_dim), so the embedding provider cannot be used at all.Useful? React with 👍 / 👎.