Skip to content

Conversation

@cpriti-os
Copy link
Contributor

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@cpriti-os cpriti-os requested review from a team as code owners November 17, 2025 05:56
@snippet-bot
Copy link

snippet-bot bot commented Nov 17, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Nov 17, 2025
@cpriti-os cpriti-os marked this pull request as draft November 17, 2025 05:57
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @cpriti-os, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new Go sample for Google Cloud Storage, specifically demonstrating how to list buckets in a project while gracefully handling scenarios where some buckets might be unreachable. It leverages the ReturnPartialSuccess feature to provide a comprehensive view of both accessible and inaccessible buckets, enhancing robustness in bucket listing operations.

Highlights

  • New Sample for Listing Buckets with Partial Success: A new Go sample, listBucketsPartialSuccess, has been added to demonstrate how to list Google Cloud Storage buckets while also identifying any unreachable buckets. This leverages the ReturnPartialSuccess option of the bucket iterator.
  • New System Test: A corresponding system test, TestListBucketsPartialSuccess, was added to storage/buckets/buckets_test.go to verify the functionality of the new sample, ensuring it correctly processes both reachable and unreachable bucket information.
  • Test File Updates (with merge conflicts): The storage/transfer_manager/download_chunks_concurrently_test.go file received updates to its TestMain function for test resource setup and teardown, and modifications to TestDownloadChunksConcurrently for temporary file handling and cleanup. Note that this file contains unresolved merge conflict markers.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new sample for listing buckets with ReturnPartialSuccess, which is well-implemented along with its test. However, there's a critical issue in storage/transfer_manager/download_chunks_concurrently_test.go which contains unresolved merge conflicts. These changes also seem unrelated to the PR's main goal. Please resolve the conflicts and consider submitting the unrelated changes in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant