Add Progressive Cavity Pump (PCP) Support #498
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caio-ramos
changed the title
caio-ramos
force-pushed
the
fb-ASIM-6417-PCP-pump-model
branch
from
593b0bd to
eb8f6db
Compare
- Add 'progressive_cavity_pump' option to PumpType enum in constants.py - Update pump_equipment_description_schema to include the new pump type - Update CHANGELOG.rst to document the new feature ASIM-6417
caio-ramos
force-pushed
the
fb-ASIM-6417-PCP-pump-model
branch
from
eb8f6db to
3913e94
Compare
caio-ramos
changed the title
caio-ramos
changed the title
caio-ramos
force-pushed
the
fb-ASIM-6417-PCP-pump-model
branch
4 times, most recently
from
521c3cf to
5372546
Compare
Added optional 'torques' array field to TablePumpDescription class to support PCP (Progressive Cavity Pump) pump models. Changes: - Add torques field to TablePumpDescription with validation logic allowing either empty or matching array length - Update TablePumpDescription schema definition - Update documentation in TablePumpDescription.txt - Update test fixtures for schema and docstring generation - Add documentation reference for torque units - Update CHANGELOG.rst ASIM-6417
caio-ramos
force-pushed
the
fb-ASIM-6417-PCP-pump-model
branch
from
8ad2d43 to
7627831
Compare
for more information, see https://pre-commit.ci
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new pump type and torque data support to enable PCP pump modeling and simulation.
Key Changes
1. New Pump Type
PumpType.2. Torques Field in TablePumpDescription
TablePumpDescriptionclassspeeds,void_fractions,flow_rates, etc.)3. Schema Updates
pump_equipment_description_schemato includeprogressive_cavity_pumptable_pump_description_schema4. Documentation
ASIM-6417