Devex: Remove Importmap plugin #6899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
📝 WalkthroughWalkthroughRemoved the generateImportMapPlugin feature: plugin implementation, its export and import/usage in Vite config, the fast-glob dependency, and a comment referencing the plugin. Changes
Sequence Diagram(s)Old build flow with plugin: sequenceDiagram
autonumber
participant Dev as Developer / Build
participant Vite as Vite Config
participant Plugin as generateImportMapPlugin
participant Rollup as Rollup Build
participant FS as File System / dist
Dev->>Vite: run build
Vite->>Plugin: configResolved() (register externals)
Vite->>Rollup: start build
Rollup->>Plugin: generateBundle() (collect vendor chunks, copy assets)
Plugin->>FS: write assets to dist/assets/lib
Plugin->>Rollup: provide import map entries
Rollup->>Plugin: transformIndexHtml() (inject importmap)
Plugin->>FS: write index.html with <script type="importmap">
New build flow without plugin: sequenceDiagram
autonumber
participant Dev as Developer / Build
participant Vite as Vite Config
participant Rollup as Rollup Build
participant FS as File System / dist
Dev->>Vite: run build
Vite->>Rollup: start build (no import-map plugin)
Rollup->>FS: write build outputs
Possibly related issues
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
💤 Files with no reviewable changes (4)
🧰 Additional context used🧠 Learnings (3)📓 Common learnings📚 Learning: 2025-11-24T19:48:23.077ZApplied to files:
📚 Learning: 2025-11-24T19:46:52.254ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (1)
Comment |
🎭 Playwright Test Results⏰ Completed at: 11/25/2025, 04:24:46 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/25/2025, 04:15:29 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.18 MB (baseline 3.18 MB) • 🟢 -6.03 kBMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 940 kB (baseline 942 kB) • 🟢 -2.55 kBGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.54 kB (baseline 7.97 kB) • 🟢 -1.43 kBTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 297 kB (baseline 306 kB) • 🟢 -8.98 kBConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 139 kB (baseline 141 kB) • 🟢 -2.19 kBReusable component library chunks
Status: 9 added / 9 removed Data & Services — 12.5 kB (baseline 12.5 kB) • 🔴 +33 BStores, services, APIs, and repositories
Status: 3 added / 3 removed Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 8.56 MB (baseline 5.7 MB) • 🔴 +2.86 MBExternal libraries and shared vendor chunks
Status: 5 added / 4 removed Other — 3.84 MB (baseline 3.87 MB) • 🟢 -26.5 kBBundles that do not match a named category
Status: 23 added / 23 removed |
DrJKL
force-pushed
the
drjkl/importmap
branch
from
51d8371 to
1cf8f5d
Compare
christian-byrne
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See this page.
┆Issue is synchronized with this Notion page by Unito