Skip to content

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Oct 16, 2025

Adds a workflow progress panel component underneath the actionbar-container.

I suggest starting a review at the extraneous changes that were needed. Including but not limited to:

  • get createTime() in queueStore
  • promptIdToWorkflowId, initializingPromptIds, and nodeProgressStatesByPrompt in executionStore
  • create_time handling in v2ToV1Adapter
  • pointer-events-auto on ComfyActionbar.vue

The rest of the changes should be contained under QueueProgressOverlay.vue, and has less of a blast radius in case something goes wrong.

pythongosssss and others added 30 commits October 8, 2025 17:31
- fix focus mode in old menu mode
- fix sizing with custom extension panels
- fix drag destination
- refactor styles
- hide legacy action section when empty
- general tidy
@benceruleanlu benceruleanlu added New Browser Test Expectations New browser test screenshot should be set by github action and removed New Browser Test Expectations New browser test screenshot should be set by github action labels Nov 17, 2025
@benceruleanlu benceruleanlu added New Browser Test Expectations New browser test screenshot should be set by github action and removed New Browser Test Expectations New browser test screenshot should be set by github action labels Nov 17, 2025
@github-actions github-actions bot removed the New Browser Test Expectations New browser test screenshot should be set by github action label Nov 17, 2025
>
{{ t('g.cancel') }}
</button>
<button
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all of the files, could you use the existing Button components? Not sure if there are other Components you could reuse, like the Modal/Dialogs/etc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be done in a followup pr, the reason is because I need to make a change to icon button's implementation to remove a '!' flagged class, and would like to get this PR in first to prevent any more snapshot regenerations (3 times already)

@benceruleanlu benceruleanlu added New Browser Test Expectations New browser test screenshot should be set by github action and removed New Browser Test Expectations New browser test screenshot should be set by github action labels Nov 19, 2025
@benceruleanlu benceruleanlu added New Browser Test Expectations New browser test screenshot should be set by github action and removed New Browser Test Expectations New browser test screenshot should be set by github action labels Nov 19, 2025
@github-actions github-actions bot removed the New Browser Test Expectations New browser test screenshot should be set by github action label Nov 19, 2025
@benceruleanlu
Copy link
Member Author

merging after some notices in slack

@benceruleanlu benceruleanlu merged commit e427150 into main Nov 19, 2025
27 checks passed
@benceruleanlu benceruleanlu deleted the bl-execution branch November 19, 2025 06:43
@benceruleanlu
Copy link
Member Author

true bliss

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a unexpected regression to the legacy UI, that the menu background color get changed accidentally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants