-
Notifications
You must be signed in to change notification settings - Fork 423
Implement workflow progress panel #6092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
More resizing changes
…/ComfyUI_frontend into pysssss/v3-floating-ui
- fix focus mode in old menu mode - fix sizing with custom extension panels
- fix drag destination
- refactor styles - hide legacy action section when empty - general tidy
| > | ||
| {{ t('g.cancel') }} | ||
| </button> | ||
| <button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all of the files, could you use the existing Button components? Not sure if there are other Components you could reuse, like the Modal/Dialogs/etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will be done in a followup pr, the reason is because I need to make a change to icon button's implementation to remove a '!' flagged class, and would like to get this PR in first to prevent any more snapshot regenerations (3 times already)
|
merging after some notices in slack |
|
true bliss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a unexpected regression to the legacy UI, that the menu background color get changed accidentally.
Adds a workflow progress panel component underneath the
actionbar-container.I suggest starting a review at the extraneous changes that were needed. Including but not limited to:
get createTime()in queueStorepromptIdToWorkflowId,initializingPromptIds, andnodeProgressStatesByPromptin executionStorecreate_timehandling in v2ToV1Adapterpointer-events-autoon ComfyActionbar.vueThe rest of the changes should be contained under
QueueProgressOverlay.vue, and has less of a blast radius in case something goes wrong.