Skip to content

Conversation

@JulianJautz
Copy link
Contributor

@JulianJautz JulianJautz commented Nov 27, 2023

Removed bug where path to temp file was set incorrectly and therefore image could not be loaded.

  • streamlined saving and loading of temp file
  • closed streams

https://jira.catrob.at/browse/PAINTROID-693

in addition, avoided kryo buffer underflow when app is started and no temp file available
should solve:
https://jira.catrob.at/browse/PAINTROID-655

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

removed bug where path to temp file was set incorrectly

- streamlined saving and loading of temp file
- closed streams
- avoid kryo buffer underflow when app is started and no temp file available
@JulianJautz JulianJautz changed the title PAINTROID_693_auto_load_file_not_found PAINTROID-693 File not found when loading temporary copies Nov 27, 2023
removed bug where path to temp file was set incorrectly

- streamlined saving and loading of temp file
- closed streams
- avoid kryo buffer underflow when app is started and no temp file available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant