"Cannot" with association hash conditions : accessible_by generates incorrect SQL (Postgres / ActiveRecord) #856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PostgreSQL can't compare null values, IS NULL must be used instead.
Contributor
Author
|
@coorasse Hi, you seem to be one of the maintainer. Any updates on this PR? It is still an issue in our applications that we can't really fix otherwise. Best regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope it's enough to link to the relevant issue #214
The commit addresses the issue at its root by checking for IS NULL. PostgreSQL can't compare null values with any other value.