Uses SETLOCAL in generated npm.cmd #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting the npm batch script. Packages running scripts using "node..." will now be executed correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses SETLOCAL to add the current node installation to path when executing the npm batch script. Packages running scripts using "node..." will now be executed correctly.
For instance, the module "node-sass" installation was failing because the module has scripts:
{ "install": "node scripts\install.js", ... }but
nodewas not recognized as a valid command because it was not in the PATH.Using SETLOCAL allows to add the local node installation to the path for the duration of the batch execution.