Reimplement legacy `Sound` class with new audio engine #17457

docEdub · 2025-11-14T21:59:03Z

No description provided.

bjsplat · 2025-11-14T22:04:35Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-11-14T22:19:29Z

Snapshot stored with reference name:
refs/pull/17457/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/17457/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17457/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17457/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17457/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17457/merge#BCU1XR#0

bjsplat · 2025-11-14T22:25:39Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-14T22:29:38Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-14T22:33:27Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-11-14T22:43:13Z

Audio test results:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/audioV2/index.html

bjsplat · 2025-11-14T22:46:54Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-17T20:46:57Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-17T20:55:16Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-17T20:56:13Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-17T20:57:54Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-11-17T21:24:34Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-17T21:32:08Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-17T21:33:41Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-17T21:35:09Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-11-17T21:38:55Z

Audio test results:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/audioV2/index.html

bjsplat · 2025-11-17T22:40:07Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-17T22:43:19Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-17T22:48:19Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-17T22:50:00Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-11-17T22:55:33Z

Audio test results:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/audioV2/index.html

…tructed

bjsplat · 2025-11-18T14:31:27Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/interactionplaywright/index.html

See playground #KBA3JY#4.

bjsplat · 2025-11-24T16:37:24Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-11-24T16:43:50Z

Audio test results:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/audioV2/index.html

…true`

Initial volume is currently `1` when `useCustomAttenuation = true`, which plays the sound for a short amount of time without using the custom attenuation value. This change sets the initial volume to `0` in this case so the sound is silent before the custom attenuation value kicks in.

bjsplat · 2025-11-25T16:05:24Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-25T16:08:30Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-25T16:14:05Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-25T16:16:45Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-11-25T16:20:02Z

Audio test results:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/audioV2/index.html

…ecified

bjsplat · 2025-11-25T19:49:36Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-25T20:01:18Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-11-25T20:02:18Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-25T20:03:11Z

Audio test results:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/audioV2/index.html

bjsplat · 2025-11-25T20:03:46Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/devhostplaywright/index.html

Timing variations are still causing tests using realtime audio context to be flaky. This change expands the acceptable value ranges for them so they are less flaky.

bjsplat · 2025-11-25T20:47:47Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-25T20:51:38Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-25T20:57:02Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-25T20:59:48Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgl2playwright/index.html

…st only

bjsplat · 2025-11-25T21:07:03Z

Audio test results:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/audioV2/index.html

bjsplat · 2025-11-25T21:32:07Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-25T21:36:13Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-25T21:40:44Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-25T21:41:28Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-11-25T21:45:45Z

Audio test results:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/testResults/audioV2/index.html

Reimplement legacy Sound class with new audio engine

7375134

Fix case where Sound is constructed but audio engine is not available

eb0bcc4

docEdub force-pushed the 251114-reimplement-old-sound-class branch from 33d1d2f to eb0bcc4 Compare November 17, 2025 21:03

docEdub added the audio label Nov 17, 2025

docEdub added 2 commits November 17, 2025 17:13

Fix sound not setting playback loop option correctly

870db99

Show unmute button when sound is set to autoplay and engine is locked

8fb0eb7

Fix autoplay property not being set correctly after Sound is cons…

f2464f6

…tructed

Fix audio engine unlock when useCustomUnlockedButton is true

ca391fe

See playground #KBA3JY#4.

docEdub added 2 commits November 25, 2025 10:29

Ensure maxDistance = Number.MAX_VALUE when `useCustomAttenuation = …

078dda0

…true`

docEdub marked this pull request as ready for review November 25, 2025 16:24

docEdub marked this pull request as draft November 25, 2025 16:24

docEdub added 2 commits November 25, 2025 14:27

Make sure maxDistance get set to legacy default correctly if not sp…

561690f

…ecified

Fix spatial audio Vector3 and Quaternion defaults getting changed

4b4534c

Relax acceptable value ranges for realtime audio contexts

c2acd3d

Timing variations are still causing tests using realtime audio context to be flaky. This change expands the acceptable value ranges for them so they are less flaky.

Relax acceptable value ranges for realtime audio contexts on flaky te…

e9f715a

…st only

Reimplement legacy Sound class with new audio engine #17457

Are you sure you want to change the base?

Reimplement legacy Sound class with new audio engine #17457

Conversation

docEdub commented Nov 14, 2025

Uh oh!

bjsplat commented Nov 14, 2025

Uh oh!

bjsplat commented Nov 14, 2025

Uh oh!

bjsplat commented Nov 14, 2025

Uh oh!

bjsplat commented Nov 14, 2025

Uh oh!

bjsplat commented Nov 14, 2025

Uh oh!

bjsplat commented Nov 14, 2025

Uh oh!

bjsplat commented Nov 14, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 17, 2025

Uh oh!

bjsplat commented Nov 18, 2025

Uh oh!

bjsplat commented Nov 24, 2025

Uh oh!

bjsplat commented Nov 24, 2025

Uh oh!

bjsplat commented Nov 25, 2025

Uh oh!

bjsplat commented Nov 25, 2025

Uh oh!

bjsplat commented Nov 25, 2025

Uh oh!

bjsplat commented Nov 25, 2025

Uh oh!

bjsplat commented Nov 25, 2025

Uh oh!

bjsplat commented Nov 25, 2025

Uh oh!

bjsplat commented Nov 25, 2025

Uh oh!

bjsplat commented Nov 25, 2025

Uh oh!

bjsplat commented Nov 25, 2025

Uh oh!

bjsplat commented Nov 25, 2025

Uh oh!

bjsplat commented Nov 25, 2025

Uh oh!

bjsplat commented Nov 25, 2025

Uh oh!

bjsplat commented Nov 25, 2025

Uh oh!

Reimplement legacy `Sound` class with new audio engine #17457

Reimplement legacy `Sound` class with new audio engine #17457