Skip to content

Use CGI.escape instead #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use CGI.escape instead #220

wants to merge 2 commits into from

Conversation

@jfine
Copy link

@jfine jfine commented Aug 18, 2022 •
edited
Loading

While using Ruby 3.1 we encountered undefined method escape' for URI:Module (NoMethodError). Utilizing CGI.escape in lieu of manually escaping single quotes and using URI.escape seems to work as expected and should allow this library to work with modern Ruby versions! 🎉

cc: @yaxia @katmsft

@dunyakirkali
Copy link

dunyakirkali commented Oct 7, 2023

And until this is merged we can only use Ruby 2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@krcm0209 krcm0209 krcm0209 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jfine @dunyakirkali @krcm0209