fix headless rendering with latest chrome #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenbreddels
requested changes
Jan 4, 2021
Collaborator
maartenbreddels
left a comment
maartenbreddels
left a comment
There was a problem hiding this comment.
Hi,
thanks for this! I have a few comments, hope you can address them.
Regards,
Maarten
| #print(str(result)) | ||
| try: | ||
| url = result['result']['result']['value'] | ||
| url = result[0]['result']['result']['value'] |
Collaborator
There was a problem hiding this comment.
why did this change, and which version, and can we make it detect this? so it also works on older versions?
Author
There was a problem hiding this comment.
Actually I don't know why/when this has changed. This seems to work fine but recently throwing the following error: "tuple indices must be integers or slices, not str". This is the main reason prompting this pull request. Since there has been no recent update to ipyvolume python module, my guess is that something else (chrome/ipyvolume js module/threejs) has been updated
maartenbreddels
force-pushed
the
master
branch
2 times, most recently
from
e861e87 to
6dead3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.