Skip to content

[Bug] Incorrect typing for GeohashLayerProps #9854

@kylebarron

Description

@kylebarron

Description

The GeohashLayerProps is defined as an object with a single attribute:

/**
* Properties of `GeohashLayer`.
*/
export type GeohashLayerProps<DataT = unknown> = {
/**
* Called for each data object to retrieve the geohash string identifier.
*
* By default, it reads `geohash` property of data object.
*/
getGeohash?: AccessorFunction<DataT, string>;
};

Instead, like the H3HexagonLayerProps, it should merge in PolygonLayerProps:

/** All properties supported by H3HexagonLayer */
export type H3HexagonLayerProps<DataT = unknown> = _H3HexagonLayerProps<DataT> &
PolygonLayerProps<DataT>;

Flavors

  • Script tag
  • React
  • Python/Jupyter notebook
  • MapboxOverlay
  • GoogleMapsOverlay
  • CARTO
  • ArcGIS

Expected Behavior

Type should include polygon layer props.

Steps to Reproduce

type definition in my node_modules for deck.gl 9.2.1:

Image

Environment

  • Framework version: 9.2.1
  • Browser: Chrome
  • OS: Mac

Logs

No response

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions