-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Open
Labels
Description
Description
The GeohashLayerProps is defined as an object with a single attribute:
deck.gl/modules/geo-layers/src/geohash-layer/geohash-layer.ts
Lines 13 to 23 in 9bfe769
| /** | |
| * Properties of `GeohashLayer`. | |
| */ | |
| export type GeohashLayerProps<DataT = unknown> = { | |
| /** | |
| * Called for each data object to retrieve the geohash string identifier. | |
| * | |
| * By default, it reads `geohash` property of data object. | |
| */ | |
| getGeohash?: AccessorFunction<DataT, string>; | |
| }; |
Instead, like the H3HexagonLayerProps, it should merge in PolygonLayerProps:
deck.gl/modules/geo-layers/src/h3-layers/h3-hexagon-layer.ts
Lines 53 to 55 in 9bfe769
| /** All properties supported by H3HexagonLayer */ | |
| export type H3HexagonLayerProps<DataT = unknown> = _H3HexagonLayerProps<DataT> & | |
| PolygonLayerProps<DataT>; |
Flavors
- Script tag
- React
- Python/Jupyter notebook
- MapboxOverlay
- GoogleMapsOverlay
- CARTO
- ArcGIS
Expected Behavior
Type should include polygon layer props.
Steps to Reproduce
type definition in my node_modules for deck.gl 9.2.1:
Environment
- Framework version: 9.2.1
- Browser: Chrome
- OS: Mac
Logs
No response