FIX set defualt [128, 128] insted of none

[ved1beta]

title

fixes #3656

[gemini-code-assist]

Summary of Changes

Hello @ved1beta, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a potential runtime error in the fp8.py kernel by ensuring that the block_size variable always has a valid default value. Previously, if block_size was not explicitly defined on either weight or weight_scale, it would default to None, causing an assertion to fail. The change provides a fallback default of [128, 128] for block_size, enhancing the robustness of the kernel's operation.

Highlights

• Bug Fix: Corrected an issue in unsloth/kernels/fp8.py where the block_size could default to None, leading to an assertion error.
• Default Value: The block_size attribute now defaults to [128, 128] when retrieved from weight_scale if it is not explicitly set, ensuring proper initialization.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a potential AssertionError by providing a default [128, 128] value for block_size. The change is sound and aligns with similar patterns elsewhere in the codebase. I have added one minor suggestion to remove a now-redundant assertion for code cleanup.

[gemini-code-assist]

With this change, block_size will always have a value, making the assertion on line 351 (assert block_size is not None) redundant. Consider removing it for better code clarity.