Merge pull request #251 from cvergne/fix/247-statictypemapper-methods-to-constructor

[Fix] Fix StaticTypeMapper method calls by moving definition

Author: andrew-demb

src/DependencyInjection/GraphQLiteCompilerPass.php

@@ -271,14 +271,12 @@ public function process(ContainerBuilder $container): void
             }
         }
 
-        if (!empty($customTypes)) {
-            $definition = $container->getDefinition(StaticTypeMapper::class);
-            $definition->addMethodCall('setTypes', [$customTypes]);
-        }
-        if (!empty($customNotMappedTypes)) {
-            $definition = $container->getDefinition(StaticTypeMapper::class);
-            $definition->addMethodCall('setNotMappedTypes', [$customNotMappedTypes]);
-        }
+        $staticMapperDefinition = new Definition(StaticTypeMapper::class, [
+            '$types' => $customTypes,
+            '$notMappedTypes' => $customNotMappedTypes
+        ]);
+        $staticMapperDefinition->addTag('graphql.type_mapper');
+        $container->setDefinition(StaticTypeMapper::class, $staticMapperDefinition);
 
         // Register graphql.queryprovider
         $this->mapAdderToTag('graphql.queryprovider', 'addQueryProvider', $container, $schemaFactory);

src/Resources/config/container/graphqlite.xml

@@ -79,10 +79,6 @@
 
         <service id="GraphQL\Validator\Rules\QueryDepth" />
 
-        <service id="TheCodingMachine\GraphQLite\Mappers\StaticTypeMapper">
-            <tag name="graphql.type_mapper"/>
-        </service>
-
         <service id="TheCodingMachine\GraphQLite\Bundle\Controller\GraphQLiteController" public="true">
             <tag name="routing.route_loader"/>
         </service>

tests/Fixtures/Entities/Book.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace TheCodingMachine\GraphQLite\Bundle\Tests\Fixtures\Entities;
+
+class Book
+{
+    public function __construct(
+        private readonly string $title
+    )
+    {
+    }
+
+    public function getTitle(): string
+    {
+        return $this->title;
+    }
+}

tests/Fixtures/Types/CustomBookType.php

@@ -0,0 +1,24 @@
+<?php
+
+namespace TheCodingMachine\GraphQLite\Bundle\Tests\Fixtures\Types;
+
+use GraphQL\Type\Definition\ObjectType;
+use GraphQL\Type\Definition\Type;
+
+class CustomBookType extends ObjectType
+{
+    public function __construct()
+    {
+        parent::__construct([
+            'name' => 'Book',
+            'description' => 'A book',
+            'fields' => [
+                'title' => [
+                    'type' => Type::nonNull(Type::string()),
+                    'description' => 'Book title',
+                ],
+            ],
+        ]);
+    }
+
+}

tests/Fixtures/config/services.yaml

@@ -20,6 +20,10 @@ services:
     TheCodingMachine\GraphQLite\Bundle\Tests\NoSecurityBundleFixtures\:
         resource: '../../NoSecurityBundleFixtures/*'
 
+    TheCodingMachine\Graphqlite\Bundle\Tests\Fixtures\Types\CustomBookType:
+        tags:
+            - { name: 'graphql.output_type', class: 'TheCodingMachine\GraphQLite\Bundle\Tests\Fixtures\Entities\Book' }
+
     someService:
         class: stdClass