Fix preview of images with non srgb icc profile

Author: leiserfg

Cargo.lock

@@ -27,6 +27,7 @@ ratatui     = { workspace = true }
 scopeguard  = { workspace = true }
 tokio       = { workspace = true }
 tracing     = { workspace = true }
+qcms = "0.3.0"
 
 [target.'cfg(target_os = "macos")'.dependencies]
 crossterm = { workspace = true, features = [ "use-dev-tty", "libc" ] }

yazi-adapter/Cargo.toml

@@ -1,7 +1,8 @@
 use std::path::{Path, PathBuf};
 
-use anyhow::Result;
+use anyhow::{Context, Result};
 use image::{DynamicImage, ExtendedColorType, ImageDecoder, ImageEncoder, ImageError, ImageReader, ImageResult, Limits, codecs::{jpeg::JpegEncoder, png::PngEncoder}, imageops::FilterType, metadata::Orientation};
+use qcms::{Profile, Transform};
 use ratatui::layout::Rect;
 use yazi_config::YAZI;
 use yazi_fs::provider::{Provider, local::Local};
@@ -31,17 +32,36 @@ impl Image {
 				encoder.write_image(&rgba, rgba.width(), rgba.height(), ExtendedColorType::Rgba8)?;
 			} else {
 				let mut encoder = JpegEncoder::new_with_quality(&mut buf, YAZI.preview.image_quality);
-				icc.map(|b| encoder.set_icc_profile(b));
-				encoder.encode_image(&img.into_rgb8())?;
+				let width = img.width();
+				let height = img.height();
+				let mut data = img.into_rgb8().into_raw();
+				Self::apply_profile(icc, &mut data)?;
+				encoder.encode(&data, width, height, ExtendedColorType::Rgb8)?
 			}
 
-			Ok::<_, ImageError>(buf)
+			Ok::<_, anyhow::Error>(buf)
 		})
 		.await??;
 
 		Ok(Local::regular(&cache).write(buf).await?)
 	}
 
+	fn apply_profile(icc: Option<Vec<u8>>, data: &mut [u8]) -> Result<()> {
+		// If ICC profile is present and it's not srgb, perform color transformation
+		if let Some(ref icc_profile) = icc
+			&& let Some(input) = Profile::new_from_slice(icc_profile, false)
+			&& !input.is_sRGB()
+		{
+			let mut output = Profile::new_sRGB();
+			output.precache_output_transform();
+
+			let xfm = Transform::new(&input, &output, qcms::DataType::RGB8, qcms::Intent::default())
+				.context("Failed creating the ICC transformer")?;
+			xfm.apply(data);
+		}
+		Ok(())
+	}
+
 	pub(super) async fn downscale(path: PathBuf, rect: Rect) -> Result<DynamicImage> {
 		let (mut img, orientation, _) = Self::decode_from(path).await?;
 		let (w, h) = Self::flip_size(orientation, Self::max_pixel(rect));
@@ -115,7 +135,6 @@ impl Image {
 			let mut decoder = reader.with_guessed_format()?.into_decoder()?;
 			let orientation = decoder.orientation().unwrap_or(Orientation::NoTransforms);
 			let icc = decoder.icc_profile().unwrap_or_default();
-
 			Ok((DynamicImage::from_decoder(decoder)?, orientation, icc))
 		})
 		.await