add GetLogs flaps machines client API #159
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetch logs from a Machine or App using the flaps client. Add an io.Reader wrapper to transform the newline-delimited JSON response into a JSON Array that can be decoded directly into a slice.
wjordan
added a commit
to superfly/flyctl
that referenced
this pull request
Jul 29, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetLogsfetches logs from either a specific Machine or (if themachineID == "") an entire App, using the flaps client.Because the API response is newline-delimited JSON, this PR also includes a wrapper function (
ndjson.Wrap) that transforms anio.ReadCloserresponse into a standard JSON Array that can be decoded directly into a slice.The structure of each log lines is
AppLogEntrywhich is the same format as NATS app-log messages (extracted from the flyctl repo).