Switch LLM streaming to OpenAI client #11138
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const DEBUG_LEVELS: DebugLevel[] = ['trace', 'debug', 'info', 'warn', 'error']; | ||
| const isProduction = process.env.NODE_ENV === 'production'; | ||
| const envDebugLevel = | ||
| (process.env.NEXT_PUBLIC_LOG_LEVEL as DebugLevel | undefined) ?? | ||
| (process.env.LOG_LEVEL as DebugLevel | undefined); |
There was a problem hiding this comment.
This module now reads process.env directly to determine the log level. Unlike the previous import.meta.env constants, process is not available in the browser or in the default Cloudflare Worker runtime, so importing this file will throw ReferenceError: process is not defined before any logging can occur. Because the logger is imported by many client-side stores and hooks, this would crash the UI in non‑Node environments. Consider reverting to compile‑time env injection or guarding the access behind a feature check.
Useful? React with 👍 / 👎.
| const apiKey = | ||
| env.NVIDIA_API_KEY || | ||
| cloudflareEnv.NVIDIA_API_KEY || | ||
| env.ANTHROPIC_API_KEY || | ||
| cloudflareEnv.ANTHROPIC_API_KEY; | ||
|
|
||
| if (!apiKey) { | ||
| throw new Error('Missing NVIDIA_API_KEY environment variable'); |
There was a problem hiding this comment.
The new streaming implementation targets NVIDIA’s OpenAI-compatible endpoint, yet getAPIKey still returns ANTHROPIC_API_KEY when no NVIDIA key is set. In environments that only configured the old Anthropic key (the previous default), the call will proceed with that key and fail at runtime with an opaque 401 instead of failing fast with a clear configuration error. Now that Env declares NVIDIA_API_KEY as required, this function should throw when that key is missing rather than silently accepting an incompatible one.
Useful? React with 👍 / 👎.
2 participants
No description provided.