Update vagrant-libvirt.md to streamline patching #12003
Closed
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--config-patch-control-plane` parameter seems very applicable here to streamline the process of manually editing the controlplane.yaml after `talosctl gen config ...` Signed-off-by: 459below <[email protected]>
Member
|
@Iheanacho-ai please take care of this PR |
|
This PR is stale because it has been open 45 days with no activity. |
Contributor
Author
|
Can I improve my PR to make it more fitting? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What? (description)
Update of documentation of the Vagrant & Libvirt howto.
Why? (reasoning)
In order to make bootstrapping a Libvirt cluster more comfortable. The
--config-patch-control-planelooks very much like the perfect fit here and introduces potential newcomers early to the powerful patching mechanic here.Acceptance
Please use the following checklist:
make conformance)make fmt)make lint)make docs)make unit-tests)