enhancement(dsl): Integrate nsjail sandbox for Python DSL execution #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SafeDep Report Summary
No dependency changes detected. Nothing to scan. This report is generated by SafeDep Github App |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
==========================================
- Coverage 80.70% 80.47% -0.23%
==========================================
Files 77 77
Lines 7736 7763 +27
==========================================
+ Hits 6243 6247 +4
- Misses 1248 1269 +21
- Partials 245 247 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Owner
Author
Merge activity
|
shivasurya
changed the base branch from
shiva/sandbox-pr01-docker
to
graphite-base/400
Add nsjail sandboxing support to dsl/loader.go for secure Python rule execution: - Add isSandboxEnabled() to check PATHFINDER_SANDBOX_ENABLED env var - Add buildNsjailCommand() to construct nsjail command with security flags - Modify loadRulesFromFile() to use nsjail when sandbox is enabled - Update entrypoint.sh to create /tmp/nsjail_root at runtime - Add test-nsjail-integration.sh for integration testing Security features: - Network isolation (--iface_no_lo) - Filesystem isolation (chroot to /tmp/nsjail_root) - Process isolation (PID namespace) - User isolation (run as nobody) - Resource limits: 512MB memory, 30s CPU, 1MB file size Implements PR-02 from python-sandboxing tech spec. Stacks on PR-01 (Docker runtime setup). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
shivasurya
force-pushed
the
shiva/sandbox-pr02-code
branch
from
47d8dd5 to
d548f58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change integrates the nsjail sandboxing capabilities into the DSL rule loader for secure Python code execution at runtime. The implementation adds conditional sandbox execution that checks an environment variable to determine whether rules should run in isolated mode or directly. When sandboxing is enabled, the system constructs nsjail commands with comprehensive security parameters including network isolation, filesystem restrictions, process separation, and resource limits. The entrypoint script ensures the sandbox environment is properly initialized before rule execution begins. Three new helper functions provide the core functionality for environment detection, command construction, and secure execution. The integration maintains backward compatibility by allowing sandbox disablement for development workflows while defaulting to secure execution in production. This completes the sandboxing architecture by connecting the runtime environment from the previous change to the actual DSL rule execution pipeline.