fix: Ensure trailing slash is added to source URIs added via gem sources #9055
+113
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub's private gem registry expects the first path segment after the host to represent the namespace, typically the organization or user name. [1] When adding a source with ``` gem sources --add https://user:[email protected]/my-org ``` without a trailing slash, the last path segment ("my-org") is interpreted as a file and removed during relative path resolution. This causes the resulting URI to become ``` https://user:[email protected]/gems/foo.gem ``` instead of the correct ``` https://user:[email protected]/my-org/gems/foo.gem. [2] ``` Example error: ``` gem source -a https://user:[email protected]/my-org gem install -rf foo.gem rubygems/remote_fetcher.rb:238:in `fetch_http': bad response Not Found 404 (https://user:[email protected]/gems/foo-0.7.1.gem) (Gem::RemoteFetcher::FetchError) ``` Although this behavior complies with RFC 2396, it's incompatible with GitHub's gem registry requirements. The remote fetcher is just append a relative path without using ./ [3] To address this, we automatically append a trailing slash when adding new gem sources. As illustrated in [4] and [5], given the base URI ``` http://a/b/c/d;p?q ``` and a relative path ``` g/f ``` the resolution process replaces "d;p?q" and yields ``` http://a/b/c/g/f ``` [1] https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-rubygems-registry#authenticating-with-a-personal-access-token [2] https://github.com/ruby/rubygems/blob/master/lib/rubygems/vendor/uri/lib/uri/generic.rb#L1053 [3] https://github.com/ruby/rubygems/blob/master/lib/rubygems/remote_fetcher.rb#L148 [4] https://www.rfc-editor.org/rfc/rfc2396#section-5.2 [5] https://www.rfc-editor.org/rfc/rfc2396#appendix-C
kou
reviewed
Nov 9, 2025
Co-authored-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub's private gem registry expects the first path segment after the host
to represent the namespace, typically the organization or user name. [1]
When adding a source with
without a trailing slash, the last path segment ("my-org") is interpreted as a
file and removed during relative path resolution. This causes the resulting
URI to become
instead of the correct
Example error:
Although this behavior complies with RFC 2396, it's incompatible with GitHub's
gem registry requirements.
The remote fetcher is just append a relative path without using ./ [3]
To address this, we automatically append a trailing slash when adding new gem
sources.
As illustrated in [4] and [5], given the base URI
and a relative path
the resolution process replaces "d;p?q" and yields
[1] https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-rubygems-registry#authenticating-with-a-personal-access-token
[2] https://github.com/ruby/rubygems/blob/master/lib/rubygems/vendor/uri/lib/uri/generic.rb#L1053
[3] https://github.com/ruby/rubygems/blob/master/lib/rubygems/remote_fetcher.rb#L148
[4] https://www.rfc-editor.org/rfc/rfc2396#section-5.2
[5] https://www.rfc-editor.org/rfc/rfc2396#appendix-C