-
Notifications
You must be signed in to change notification settings - Fork 30
Fix make_shareable shim in harness-common.rb #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
de70988 to
b5f1f6b
Compare
* Ractor is not defined on non-CRuby.
b5f1f6b to
0e1ee81
Compare
|
Mmh, it's not great to define So I think we should either define |
|
I think since this is mostly for shim a method that doesn't exist anyway in some Ruby implementation |
* Defining Ractor causes issues with gems assuming the rest of Ractor is available, like: lib/mri/psych.rb:709:in `config': undefined method `current' for class Ractor (NoMethodError)
|
Done, and updated benchmarks to use |
Example failure: https://github.com/ruby/ruby-bench/actions/runs/19580397581/job/56076559112#step:4:13