Support relative includes for IDL in local message definition #2241
+180
−65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR fixes relative includes for IDL format. If the user has an IDL file that is in the same directory
as the parent message, and the parent message is being recorded, rosbag2 will crash without reporting
an error. This is avoided by adding a new
namespace_hintparameter, modifying the regex used to searchfor includes, and applying that information when there is no package nor namespace provided for dependency
collection.
Is this user-facing behavior change?
No.
Did you use Generative AI?
No.
Additional Information
n/a