-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Description
Details
In pip-tools, our RTD config sets build.tools: {}. (ref)
I can't recall why -- it wasn't something we discussed with the new config -- maybe I thought it was more explicit? I think just omitting tools would be equivalent, but I don't feel 100% certain of that?
When we went to add schema validation to our lints (check-jsonschema in pre-commit), we were surprised to see it fail.
The failure is caused by "minProperties": 1 being set here on the schema for build.tools.
I'd like to update and relax the schema, allowing the empty object, on the grounds that it is allowed by RTD when loading config and executing a build.
Expected Result
The config, which works, should pass validation against the RTD schema.
Actual Result
The schema and service are in disagreement, and the working config fails validation.
I intend to open a PR for this momentarily. If the change is unacceptable for some reason (e.g., RTD is trying to migrate to require this), but I can get confirmation that omitting build.tools is equivalent to specifying it as empty, that would be helpful as an alternative.