-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Add sports-scores extension #23123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add sports-scores extension #23123
Conversation
|
Congratulations on your new Raycast extension! 🚀 You can expect an initial review within five business days. Once the PR is approved and merged, the extension will be available on our Store. |
Greptile OverviewGreptile SummaryThis PR adds a new Key Changes:
Issues Found:
Overall Assessment: Confidence Score: 4/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
21 files reviewed, 2 comments
| { | ||
| "singleQuote": true, | ||
| "printWidth": 100 | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Use Raycast's standard Prettier configuration instead of custom settings
| { | |
| "singleQuote": true, | |
| "printWidth": 100 | |
| } | |
| { | |
| "printWidth": 120, | |
| "singleQuote": false | |
| } |
Context Used: Rule from dashboard - Extensions should use the standard Raycast Prettier configuration: `{"printWidth": 120, "singleQuote... (source)
| const prettier = require("eslint-config-prettier/flat"); | ||
| const typescript = require("typescript-eslint"); | ||
| const raycast = require("@raycast/eslint-plugin"); | ||
| const js = require("@eslint/js"); | ||
| const globals = require("globals"); | ||
|
|
||
| module.exports = [ | ||
| js.configs.recommended, | ||
| ...typescript.configs.recommended, | ||
| { | ||
| languageOptions: { | ||
| ecmaVersion: 2022, | ||
| globals: { | ||
| ...globals.node, | ||
| }, | ||
| }, | ||
| }, | ||
| ...raycast.configs.recommended, // Spread the array here | ||
| prettier, | ||
| ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Use the standard Raycast ESLint template
| const prettier = require("eslint-config-prettier/flat"); | |
| const typescript = require("typescript-eslint"); | |
| const raycast = require("@raycast/eslint-plugin"); | |
| const js = require("@eslint/js"); | |
| const globals = require("globals"); | |
| module.exports = [ | |
| js.configs.recommended, | |
| ...typescript.configs.recommended, | |
| { | |
| languageOptions: { | |
| ecmaVersion: 2022, | |
| globals: { | |
| ...globals.node, | |
| }, | |
| }, | |
| }, | |
| ...raycast.configs.recommended, // Spread the array here | |
| prettier, | |
| ]; | |
| const { defineConfig } = require("eslint/config"); | |
| const raycastConfig = require("@raycast/eslint-config"); | |
| module.exports = defineConfig([ | |
| ...raycastConfig, | |
| ]); |
|
Hi @ari1110👋 Thanks for your contribution 🔥 Did you see similar extensions in the store before building this (we should try to enhance if possible) |
|
Nice to meet you! Yes, I did check out what was currently available, but it wasn't windows compatible. I also think what I've implemented is a much simpler version of just scoreboard information rather than what Daniyal has pushed to the store. I think there's room, if anything for both to co-exist. Let me know your thoughts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
21 files reviewed, 3 comments
|
Hi 👋 That it's not compabile with Windows is the least, you could open a PR with that enhancement - they do feel pretty related actually, what do you think @daniyalmaster693 In our Extensions Guidelines you'll see that you should try to enhance rather than creating a new extension Is there some places you think it's way different that couldn't be enhanced? |

Description
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder