Signature of Minecraft constructor has changed - previously took a connection

[jonathanfine]

In 6eeb804 we have

class Minecraft:
    """The main class to interact with a running instance of Minecraft Pi."""
    def __init__(self, connection):
        self.conn = connection

In 9f3bfba we have

class Minecraft:
    """The main class to interact with a running instance of Minecraft Pi."""
    def __init__(self, address="localhost", port=4711):
        self._conn = Connection(address, port)

[doismellburning]

Noted; if you could please make a PR with test and fix, thanks

[jonathanfine]

@doismellburning wrote

Noted; if you could please make a PR with test and fix, thanks

Please see #57 Compatibility of code base with previous version not obvious.

The only way to fix both issues is to go back to 6eeb804. I'm not interested in contributing to fixing this issue without fixing #57 (which is in many ways the root cause of this issue and perhaps other,unknown, issues).

In fact, the whole test framework that needs to be revised. See #61 Test framework does not test previous version. Once #61 is fixed we will have the failing test for this issue, and perhaps some other failing tests.