-
Notifications
You must be signed in to change notification settings - Fork 6.1k
executor: recognize PointGet and BatchPointGet in admin check #64792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
executor: recognize PointGet and BatchPointGet in admin check #64792
Conversation
|
Hi @shenyv1. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @shenyv1! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @shenyv1. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The verifyIndexSideQuery function verifies index-side queries use index access instead of table scan. It previously only recognized IndexFullScan and IndexRangeScan, causing admin check to fail when PointGet or BatchPointGet plans are generated for enum columns or unique indexes. Add PointGet and BatchPointGet recognition to fix this issue. Close pingcap#64731
14883ae to
3c865a9
Compare
|
/release-note |
|
@shenyv1: the In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Please consider that point get may not be a index access |
What problem does this PR solve?
Issue Number: close #64731
Problem Summary:
The verifyIndexSideQuery function didn't recognize PointGet and BatchPointGet
as valid index access methods, causing ADMIN CHECK to fail when checking indexes
on enum columns or unique indexes.
What changed and how does it work?
Modified the verifyIndexSideQuery function to accept PointGet and BatchPointGet
operators as valid index access plans, in addition to IndexFullScan and IndexRangeScan.
Check List
Tests
Side effects
Documentation
Release note