Skip to content

Conversation

@fzzf678
Copy link
Contributor

@fzzf678 fzzf678 commented Dec 1, 2025

What problem does this PR solve?

Issue Number: ref #62122

Problem Summary:

What changed and how does it work?

It's my mistake use the error number 3809 of db read only which is incorrect and inconsistent with mysql 🤦‍♂️. Should follow mysql's 3989:

mysql> alter schema test read only 1;
Query OK, 1 row affected (0.01 sec)

mysql> drop database test;
ERROR 3989 (HY000): Schema 'test' is in read only mode.
mysql> select version();
+-----------+
| version() |
+-----------+
| 8.0.31    |
+-----------+
1 row in set (0.00 sec)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 1, 2025
@tiprow
Copy link

tiprow bot commented Dec 1, 2025

Hi @fzzf678. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (feature/release-8.5-read_only@d209de2). Learn more about missing BASE report.

Additional details and impacted files
@@                        Coverage Diff                         @@
##             feature/release-8.5-read_only     #64788   +/-   ##
==================================================================
  Coverage                                 ?   77.1208%           
==================================================================
  Files                                    ?       1642           
  Lines                                    ?     450563           
  Branches                                 ?          0           
==================================================================
  Hits                                     ?     347478           
  Misses                                   ?      81706           
  Partials                                 ?      21379           
Flag Coverage Δ
integration 50.3217% <ø> (?)
unit 72.6676% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 63.0012% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fzzf678 fzzf678 changed the title ddl: correct the errno of database read only ddl: correct the errno of database read only | tidb-test=release-8.5.2 Dec 1, 2025
@fzzf678
Copy link
Contributor Author

fzzf678 commented Dec 1, 2025

/retest

@tiprow
Copy link

tiprow bot commented Dec 1, 2025

@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 2, 2025

@joechenrh: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joechenrh
Once this PR has been reviewed and has the lgtm label, please assign benjamin2037 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants