Fix /dev/tty check

Previously this was bugged, incorrectly using -z so that the check never
passed, and $EDITOR was always run without having the TTY injected as
an input. This causes problems with command-line editors like Vim, which
need an interactive input (and output) to be usable.

Meanwhile, attempting to inject /dev/tty as the input in all cases
causes problems in CI, because there is no TTY available in GitHub
Actions, and presumably in other scripted environments.

Fixing this with -e does not work, as /dev/tty exists but unopenably in
many environments. Instead, we use printf in a subshell to test whether
/dev/tty is actually usable, and then only use it if it is.

Author: pimterry

notes

@@ -204,8 +204,8 @@ open_note() {
 
     note_path=$( get_full_note_path "$note_path" )
 
-    if [[ -z "/dev/tty" ]]; then
-        $EDITOR "$note_path" < /dev/tty
+    if bash -c "printf '' >/dev/tty" >/dev/null 2>/dev/null; then
+        $EDITOR "$note_path" </dev/tty
     else
         $EDITOR "$note_path"
     fi

test/test-open.bats

@@ -24,7 +24,7 @@ notes="./notes"
   run $notes open
 
   assert_success
-  assert_output "Opening $HOME/notes" 
+  assert_output "Opening $HOME/notes"
 }
 
 @test "Opens the configured notes directory if set" {
@@ -132,3 +132,47 @@ notes="./notes"
   assert_success
   assert_output "Editing $NOTES_DIRECTORY/test-note.txt"
 }
+
+@test "Gives a TTY input to EDITOR when available" {
+  if ! bash -c "printf '' >/dev/tty" >/dev/null 2>/dev/null; then
+    # If no working TTY is available, we can't test this, skip it
+    skip
+  fi
+
+  function checkTtyEdit() {
+    if [ -t 0 ]; then
+      echo "Editing $* with TTY"
+    else
+      echo "No TTY to edit $*"
+    fi
+  }
+  export -f checkTtyEdit
+  export EDITOR="checkTtyEdit"
+
+  touch $NOTES_DIRECTORY/note.md
+
+  run bash -c "$notes find | $notes open test-note"
+
+  assert_success
+  assert_output "Editing $NOTES_DIRECTORY/note.md with TTY"
+}
+
+@test "Opens editor with no TTY input if none is available" {
+  function checkTtyEdit() {
+    if [ -t 0 ]; then
+      echo "Editing $* with TTY"
+    else
+      echo "No TTY to edit $*"
+    fi
+  }
+  export -f checkTtyEdit
+  export EDITOR="checkTtyEdit"
+
+  touch $NOTES_DIRECTORY/note.md
+
+  # Setsid removes the controlling TTY:
+  run setsid bash -c "$notes find | $notes open test-note"
+
+  assert_success
+  assert_output "No TTY to edit $NOTES_DIRECTORY/note.md"
+}