Reduce dependency graph by bumping dependencies #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating these two direct dependencies reduces the number of indirect dependencies to almost zero. The "gopkg.in/yaml.v2" module has moved to "go.yaml.in/yaml/v2" and is now maintained by the YAML organization on GitHub. See: https://www.github.com/pelletier/go-toml/issues/872 See: https://www.github.com/yaml/go-yaml/discussions/11
Author
$ (main) go mod graph | wc -l
23
$ (fewer-deps) go mod graph | wc -l
6 |
Owner
|
I'm happy to dig into this but just to be clear "the number of indirect dependencies" is not a number that needs to be optimized for 😇 The ff module and its deps is always imported by something else, those importers will specify transitive dep versions as they require, and it is those end-user go.mods which dictate the ultimate compilation graph, not anything in ff itself. |
Author
|
True! I find things like this help with unsophisticated scanners in my day job: licenses, vulnerabilities, and such. Certainly no urgency from me on this. 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating these two direct dependencies reduces the number of indirect dependencies to almost zero. The
gopkg.in/yaml.v2module has moved togo.yaml.in/yaml/v2and is now maintained by the YAML organization on GitHub.Fixes: #154
See: https://www.github.com/pelletier/go-toml/issues/872
See: https://www.github.com/yaml/go-yaml/discussions/11