net-api: change TryFrom<IpAddress> to just From #2303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out, the TryFrom impl for smoltcp's IpAddress can't fail. This changed in 2023 with the upgrade to smoltcp 0.9, which made the shape of IpAddress depend on which protocol features we'd selected, removing the "unreachable" variants. This commit converts the impl to From, making it clear that it can't fail and eliminating an unwrap at its (apparently single) use site.
hawkw
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out, the TryFrom impl for smoltcp's IpAddress can't fail. This changed in 2023 with the upgrade to smoltcp 0.9, which made the shape of IpAddress depend on which protocol features we'd selected, removing the "unreachable" variants.
This commit converts the impl to From, making it clear that it can't fail and eliminating an unwrap at its (apparently single) use site.