-
Notifications
You must be signed in to change notification settings - Fork 3.6k
update minimumReleaseAge
#25057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update minimumReleaseAge
#25057
Conversation
|
Updated 9:39 PM PT - Nov 24th, 2025
❌ @dylan-conway, your commit 373a0fc has 3 failures in
🧪 To try this PR locally: bunx bun-pr 25057That installs a local version of the PR into your bun-25057 --bun |
|
Caution Review failedThe pull request is closed. WalkthroughConfiguration value for minimumReleaseAge changed from 1 to 259200 in bunfig.toml; the Zig handler in src/bunfig.zig was updated to treat the field as seconds (variable/branch renamed to seconds) and still converts the value to milliseconds for internal use. Changes
Possibly related PRs
Suggested reviewers
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Comment |
bunfig.toml
Outdated
| [install] | ||
| linker = "isolated" | ||
| minimumReleaseAge = 1 | ||
| minimumReleaseAge = 259200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd add a comment here saying its 3 days instead of magic number tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea, updated
What does this PR do?
How did you verify your code works?