Skip to content

Conversation

@dylan-conway
Copy link
Member

What does this PR do?

How did you verify your code works?

@robobun
Copy link
Collaborator

robobun commented Nov 25, 2025

Updated 9:39 PM PT - Nov 24th, 2025

@dylan-conway, your commit 373a0fc has 3 failures in Build #32384 (All Failures):


🧪   To try this PR locally:

bunx bun-pr 25057

That installs a local version of the PR into your bun-25057 executable, so you can run:

bun-25057 --bun

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 25, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Configuration value for minimumReleaseAge changed from 1 to 259200 in bunfig.toml; the Zig handler in src/bunfig.zig was updated to treat the field as seconds (variable/branch renamed to seconds) and still converts the value to milliseconds for internal use.

Changes

Cohort / File(s) Change Summary
minimumReleaseAge Unit Transition
bunfig.toml, src/bunfig.zig
bunfig.toml: minimumReleaseAge changed from 1 to 259200. src/bunfig.zig: renamed branch/variable from days to seconds, updated conditional and value usage to seconds.value, retained conversion to milliseconds.

Possibly related PRs

Suggested reviewers

  • RiskyMH
  • alii

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is empty, containing only the template headings without any actual content explaining the changes or verification steps. Fill in both required sections: explain what minimumReleaseAge changes accomplish and how the changes were verified (e.g., testing, validation methods).
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: updating the minimumReleaseAge configuration value from 1 to 259200 across the codebase.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 373a0fc and 9560327.

📒 Files selected for processing (1)
  • bunfig.toml (1 hunks)

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Comment @coderabbitai help to get the list of available commands and usage tips.

bunfig.toml Outdated
[install]
linker = "isolated"
minimumReleaseAge = 1
minimumReleaseAge = 259200
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd add a comment here saying its 3 days instead of magic number tho

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, updated

@dylan-conway dylan-conway merged commit 2fb3aa8 into main Nov 25, 2025
5 checks passed
@dylan-conway dylan-conway deleted the dylan/update-minimum-release-age branch November 25, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants