Migrating a method with generics (spring-batch StepBuilder#chunk)

[crankydillo]

I'm trying to move to Spring-batch 5.2 and need to move codebases from StepBuilder#<I, O>chunk(int) to StepBuilder#<I, O>chunk(int, PlatformTransactionManager and do something similar for tasklet.

I have the following tests. The tasklet recipe works, the chunk one does not. It doesn't even get past initial type validation of the before-code snippet. Am I doing something obviously wrong? The before code compiles. When I turned off type validation in the test, I noticed it (unsurprisingly) didn't pass a UsesMethod-based precondition because compilationUtnil.getTypesInUse().getUsedMethods() doesn't return chunk (just the constructor). In tasklet case, that call does return tasklet.

I have not been able to craft a stand-alone, easy reproducer. It doesn't feel like a spring-batch bugs, so didn't want to add this to rewrite-spring.

    @Override
    public void defaults(final RecipeSpec spec) {
        spec.parser(JavaParser.fromJavaVersion()
                .classpathFromResources(new InMemoryExecutionContext(),
                        "spring-tx-6.2.10",
                        "spring-batch-core-5.2.2"
                ));
    }

    @Test
    @DisplayName("StepBuilder#tasklet(Tasklet) -> StepBuilder#tasklet(Tasklet, PlatformTransactionManager)")
    void testTasklet() {
        rewriteRun(
                spec -> spec.recipe(new AddTransactionManagerToStepBuilder())
                , java(
                        """
                        import org.springframework.batch.core.step.builder.StepBuilder;
                        import org.springframework.batch.core.step.tasklet.Tasklet;
                        
                        class Test {
                            void test(Integer someInt, int i) {
                                Tasklet task = null;
                                return new StepBuilder("step")
                                    .tasklet(task);
                            }
                        }
                        """, """
                        import org.springframework.batch.core.step.builder.StepBuilder;
                        import org.springframework.batch.core.step.tasklet.Tasklet;
                        import org.springframework.transaction.PlatformTransactionManager;
                        
                        class Test {
                            void test(Integer someInt, int i, final PlatformTransactionManager platformTransactionManager) {
                                Tasklet task = null;
                                return new StepBuilder("step")
                                    .tasklet(task, platformTransactionManager);
                            }
                        }
                        """
                )
        );
    }

    @Test
    @DisplayName("StepBuilder#chunk(int) -> StepBuilder#chunk(int, PlatformTransactionManager)")
    void testChunk() {
        // This test is failing due to a type problem in the before-code snippet.  I think
        // this is an OpenRewrite issue, but need to verify.  Some quick testing without
        // this particular lib did not demonstrate the problem.
        rewriteRun(
                spec -> spec.recipe(new AddTransactionManagerToStepBuilder()))
                , java(
                        """
                        import org.springframework.batch.core.step.builder.StepBuilder;
                        
                        class Test {
                            void test(Integer someInt, int i) {
                                return new StepBuilder("step").chunk(123);
                            }
                        }
                        """, """
                        import org.springframework.batch.core.step.builder.StepBuilder;
                        import org.springframework.transaction.PlatformTransactionManager;
                        
                        class Test {
                            void test(Integer someInt, int i, final PlatformTransactionManager platformTransactionManager) {
                                return new StepBuilder("step").chunk(123, platformTransactionManager);
                            }
                        }
                        """
                )
        );
    }

[timtebeek]

I can't see if you're passing any classpathFromResources entry (or similar) here to compile the inputs; If you're considering a contribution feel free to open a draft early, as that's easier to execute and provide a fix on. 🙏🏻

[timtebeek]

I recall at the time the List to Chunk migration was a bit tricky; and now it seems they've added another parameter. Fun.

[crankydillo]

Sorry about that. I added the defaults entry.

I can't see if you're passing any classpathFromResources entry (or similar) here to compile the inputs; If you're considering a contribution feel free to open a draft early, as that's easier to execute and provide a fix on. 🙏🏻

I'll see if I can reproduce this in rewrite-spring. I think I started on that.

[crankydillo]

Here you go: openrewrite/rewrite-spring#781

[timtebeek]

Thanks! I'm traveling so it'll take me a bit longer to look at this. If you want an answer from my colleagues then slack might work to notify them.

[crankydillo]

openrewrite/rewrite-spring#781 failed when I created it (demonstrating this issue), but it seems like a code change somewhere fixed this.