Skip to content

recipe produces not compiling code during JFall preconference workshop #840

@nicenemo

Description

@nicenemo

What version of OpenRewrite are you using?

Latest provided by the maven plugin ran from the commandline

How are you running OpenRewrite?

During a Workshop at the JFall preconference I migrated an old toy project, Jnoaber, from Java 8 to Java 25.
For this I used gemini CLI.
It compiles and it runs. See [this Branch] (https://github.com/nicenemo/jnoaber/tree/improved_testing)

Next I ran the following recipe with the mvn commandline:

mvn -U org.openrewrite.maven:rewrite-maven-plugin:run -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-testing-frameworks:RELEASE -Drewrite.activeRecipes=org.openrewrite.java.testing.junit5.JUnit5BestPractices -Drewrite.exportDatatables=true

I don't include openrewrite plugins in my pom.xml.

This gave the following message:

[INFO] Printing available datatables to: target/rewrite/datatables/2025-11-05_14-33-24-904
[WARNING] Changes have been made to src/test/java/eu/hanskruse/noaber/test/ComposeTest.java by:
[WARNING]     org.openrewrite.java.testing.junit.JupiterBestPractices
[WARNING]         org.openrewrite.java.testing.cleanup.RemoveTestPrefix
[WARNING]         org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
[WARNING] Changes have been made to src/test/java/eu/hanskruse/noaber/test/EitherTest.java by:
[WARNING]     org.openrewrite.java.testing.junit.JupiterBestPractices
[WARNING]         org.openrewrite.java.testing.junit5.CleanupAssertions
[WARNING]             org.openrewrite.java.testing.cleanup.AssertEqualsBooleanToAssertBoolean
[WARNING]             org.openrewrite.java.testing.cleanup.AssertNotEqualsBooleanToAssertBoolean
[WARNING]         org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
[WARNING] Changes have been made to src/test/java/eu/hanskruse/noaber/test/PatternMatchingTest.java by:
[WARNING]     org.openrewrite.java.testing.junit.JupiterBestPractices
[WARNING]         org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
[WARNING] Changes have been made to src/test/java/eu/hanskruse/noaber/test/RightAppliedTest.java by:
[WARNING]     org.openrewrite.java.testing.junit.JupiterBestPractices
[WARNING]         org.openrewrite.java.testing.cleanup.RemoveTestPrefix
[WARNING]         org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
[WARNING] Changes have been made to src/test/java/eu/hanskruse/noaber/test/StreamableTest.java by:
[WARNING]     org.openrewrite.java.testing.junit.JupiterBestPractices
[WARNING]         org.openrewrite.java.testing.cleanup.RemoveTestPrefix
[WARNING]         org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
[WARNING] Changes have been made to src/test/java/eu/hanskruse/noaber/test/TupleTest.java by:
[WARNING]     org.openrewrite.java.testing.junit.JupiterBestPractices
[WARNING]         org.openrewrite.java.testing.cleanup.RemoveTestPrefix
[WARNING]         org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
[WARNING]         org.openrewrite.java.testing.junit5.AssertTrueInstanceofToAssertInstanceOf
[WARNING] Please review and commit the results.
[WARNING] Estimate time saved: 14m

This does not compile because an import for assertInstanceOf is now missing in the TupleTest.java class.

I checked in the failing code here

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions