[stable29] multi-instance object store #56691
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
icewind1991
force-pushed
the
stable29-backports
branch
2 times, most recently
from
641de93 to
c98c9cb
Compare
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
stable29-backports
branch
from
c98c9cb to
655c14e
Compare
Altahrim
reviewed
Dec 1, 2025
| } | ||
| $this->config->setSystemValue('objectstore', $configs); | ||
| } else { | ||
| return 0; |
Collaborator
There was a problem hiding this comment.
Maybe display the piece of config to add here ?
| $config = $target; | ||
| } | ||
| } | ||
| $this->config->setSystemValue('objectstore', $configs); |
Collaborator
There was a problem hiding this comment.
When it duplicates a configuration it use the same bucket and later fails with:
Each object store configuration must use distinct bucket names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧