Skip to content

Conversation

@sv-hyacoub
Copy link
Collaborator

@sv-hyacoub sv-hyacoub commented Aug 1, 2025

Relevant Links

Bugzilla: 1980387

Description of Code / Doc Changes

Added [GB] Peacocks page and locators for address and credit card.
Skipped CC since the form is in an iframe.

Process Changes Required

Mark the relevant boxes:

  • Adds a dependency (rerun pipenv install)
  • Changes the BasePage
  • Changes or creates a BOM/POM (name the object model): _
  • Changes CI flow
  • Changes scheduled Beta or DevEdition
  • Changes Git hooks or Github settings
  • Changes L10n harness

Screenshots or Explanations

If you need to explain your code, do it here.

Comments or Future Work

Do we need to start another PR soon to address something you saw while working on this?

Workflow Checklist

  • Please request reviewers
  • If this is an unblocker, please post in Slack.
  • If asked to address comments, please resolve conversations.
  • If asked to change code, please re-request review from the person who wanted changes.

Thank you!

@soncuteanca soncuteanca self-requested a review August 1, 2025 12:59
Tracy-Walker
Tracy-Walker previously approved these changes Aug 4, 2025
Copy link
Collaborator

@Tracy-Walker Tracy-Walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@soncuteanca soncuteanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sv-hyacoub sv-hyacoub merged commit 41690d5 into main Aug 5, 2025
18 checks passed
@sv-hyacoub sv-hyacoub deleted the Hani/cm-peacocks-gb branch August 5, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants