Skip to content

enhance cosine similarity #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2024
Merged

enhance cosine similarity #268

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29c59b5
enhance cosine similarity
omarmahamid Nov 16, 2024
4c9c219
float instead of double
omarmahamid Nov 16, 2024
49e5ff5
Update VectorOperations.java
omarmahamid Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions ...el-api/src/main/java/com/microsoft/semantickernel/data/vectorsearch/VectorOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,21 @@ public static float cosineSimilarity(@Nonnull List<Float> x, @Nonnull List<Float
throw new SKException("Vectors lengths must be equal");
}

float dotProduct = dot(x, y);
float normX = dot(x, x);
float normY = dot(y, y);
float dotProduct = 0.0F;
float normX = 0.0F;
float normY = 0.0F;

for (int i = 0; i < x.size(); i++) {
dotProduct += x.get(i) * y.get(i);
normX += x.get(i) * x.get(i);
normY += y.get(i) * y.get(i);
}

if (normX == 0 || normY == 0) {
throw new SKException("Vectors cannot have zero norm");
}

return dotProduct / (float) (Math.sqrt(normX) * Math.sqrt(normY));
return (dotProduct / (float) (Math.sqrt(normX) * Math.sqrt(normY)));
}

/**
Expand Down