Merge pull request #268 from omarmahamid/enahnce-cosine-similarity

enhance cosine similarity

Author: johnoliver

semantickernel-api/src/main/java/com/microsoft/semantickernel/data/vectorsearch/VectorOperations.java

@@ -38,15 +38,21 @@ public static float cosineSimilarity(@Nonnull List<Float> x, @Nonnull List<Float
             throw new SKException("Vectors lengths must be equal");
         }
 
-        float dotProduct = dot(x, y);
-        float normX = dot(x, x);
-        float normY = dot(y, y);
+        float dotProduct = 0.0F;
+        float normX = 0.0F;
+        float normY = 0.0F;
+
+        for (int i = 0; i < x.size(); i++) {
+            dotProduct += x.get(i) * y.get(i);
+            normX += x.get(i) * x.get(i);
+            normY += y.get(i) * y.get(i);
+        }
 
         if (normX == 0 || normY == 0) {
             throw new SKException("Vectors cannot have zero norm");
         }
 
-        return dotProduct / (float) (Math.sqrt(normX) * Math.sqrt(normY));
+        return (dotProduct / (float) (Math.sqrt(normX) * Math.sqrt(normY)));
     }
 
     /**