chore(ebpf): update bpf header files #1928
Conversation
nddq
force-pushed
the
nddq/bpfHeaders
branch
2 times, most recently
from
ecc0cac to
604acb8
Compare
timraymond
left a comment
timraymond
left a comment
There was a problem hiding this comment.
I'm going to assume that the Makefile and the Dockerfiles should be the prime focus of reviews here... and the others are just generated from those. Is that right, or is there anything else that should have eyes on it?
| ARG VERSION | ||
| ENV GOARCH=${GOARCH} | ||
| ENV GOOS=${GOOS} | ||
| ENV CGO_ENABLED=0 |
There was a problem hiding this comment.
Would using //go:build ignore in placeholder.go remove the need to set CGO_ENABLED=0?
There was a problem hiding this comment.
this wouldn't work since we still need to do blank imports on those placeholder packages so that everything is vendored when you do go mod vendor
| } | ||
|
|
||
| #ifdef ADVANCED_METRICS | ||
| #if ADVANCED_METRICS == 1 |
There was a problem hiding this comment.
Do you need this line? If ADVANCED_METRICS is defined to be anything, you could consider it truthy. Just thinking of the traditional inclusion guard of:
#ifndef SOMETHING_H
#define SOMETHING_H
// ...
#endifThere was a problem hiding this comment.
we could, but im keeping it uniform with the other ADVANCED_METRICS check in the same file, we can do this refactor in a different PR
|
Any updates on this PR? |
This patch updates the bpf header files, as well as introduce Make commands to help updating these files in the future. Also update the Dockerfile for building the agent and generating Go codes. Signed-off-by: Quang Nguyen <[email protected]>
This patch updates the bpf header files from upstream libbpf, as well as introduce Make commands to help updating these files in the future. Also update the Dockerfiles for building the agent and generating Go codes.
Description
Please provide a brief description of the changes made in this pull request.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.