Skip to content

Conversation

@samrueby
Copy link
Contributor

@samrueby samrueby commented Nov 25, 2025

Summary of the Pull Request

PR Checklist

  • Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end-user-facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed


try
{
// Try to compute using container positions; if not available, fallback to simple +/-1.

Check failure

Code scanning / check-spelling

Forbidden Pattern Error

fallback matches a line_forbidden.patterns entry: "\\bfallback(?= to)\\b". (forbidden-pattern)
@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 1
⚠️ ignored-expect-variant 1

See ❌ Event descriptions for more information.

These words are not needed and should be removed cabstr CIBUILD claude cziplib Deeplink djwsxzxb GIFs installscopeperuser ksa Olllama Qualcomm registryroot regroot rtm suntimes TARGETDIR utm

Forbidden patterns 🙅 (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

Should be fall back

\bfallback(?= to)\b
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@jiripolasek jiripolasek added the Product-Command Palette Refers to the Command Palette utility label Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Product-Command Palette Refers to the Command Palette utility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CmdPal: Arrow keys don't move logically in Grid pages

2 participants