Fix calculation of sha256 sum for archives (fixes #37) #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sum over the actual archive, not the executable.
Hind-M
reviewed
Apr 17, 2025
| # compute the sha256 | ||
| sha256 = hashlib.sha256() | ||
| with open(outdir / f"micromamba-{dplat}", "rb") as f: | ||
| with open(outdir / f"micromamba-{dplat}{ext}", "rb") as f: |
Member
There was a problem hiding this comment.
Thanks for tackling this.
There are actually 2 checksums to compute and write (one for the archive and another for the executable) and they need to be written in the corresponding .sha256 files.
So we would need to add another sha256 for either the executable (if you change this line) or leave this as is and add the one for the archive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sum over the actual archive, not the executable.